From 34056f8e3575fcda220c2616aebf0ece4b3829be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20M=C3=BCller?= <tmueller@nvidia.com>
Date: Thu, 9 Feb 2023 09:42:42 +0100
Subject: [PATCH] More correct accumulation reset upon setting the training
 view

---
 src/testbed.cu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/testbed.cu b/src/testbed.cu
index b30526a..2f06b23 100644
--- a/src/testbed.cu
+++ b/src/testbed.cu
@@ -421,29 +421,27 @@ void Testbed::set_view_dir(const Vector3f& dir) {
 void Testbed::first_training_view() {
 	m_nerf.training.view = 0;
 	set_camera_to_training_view(m_nerf.training.view);
-	reset_accumulation();
 }
 
 void Testbed::last_training_view() {
 	m_nerf.training.view = m_nerf.training.dataset.n_images-1;
 	set_camera_to_training_view(m_nerf.training.view);
-	reset_accumulation();
 }
 
 void Testbed::previous_training_view() {
 	if (m_nerf.training.view != 0) {
 		m_nerf.training.view -= 1;
 	}
+
 	set_camera_to_training_view(m_nerf.training.view);
-	reset_accumulation();
 }
 
 void Testbed::next_training_view() {
 	if (m_nerf.training.view != m_nerf.training.dataset.n_images-1) {
 		m_nerf.training.view += 1;
 	}
+
 	set_camera_to_training_view(m_nerf.training.view);
-	reset_accumulation();
 }
 
 void Testbed::set_camera_to_training_view(int trainview) {
@@ -459,6 +457,8 @@ void Testbed::set_camera_to_training_view(int trainview) {
 
 	m_screen_center = Vector2f::Constant(1.0f) - m_nerf.training.dataset.metadata[trainview].principal_point;
 	m_nerf.training.view = trainview;
+
+	reset_accumulation(true);
 }
 
 void Testbed::reset_camera() {
-- 
GitLab